Actions
Bug #1253
openuse / harden checks of getline
Start date:
09/15/2010
Due date:
% Done:
0%
Estimated time:
Description
2010-09-15T12:32:38+0200
we have 4 cases of
warning: unused variable ‘isReadingCorrect’
that could be further exploited.
src/CrocusConfig.cxx: In ScanFromResult?(std::istream&, Crocus::ui32&) src/CrocusConfig.cxx:280:8: src/CrocusConfig.cxx: In ScanFromFeC2 (const std::string&) src/CrocusConfig.cxx:648:12: src/CrocusConfig.cxx: In ReadPedestalConfig? (const std::string&, double) src/CrocusConfig.cxx:840:10: src/CrocusConfig.cxx:848:10: int llPatchBus1 = -1; in.get (first); while (first == '/') { bool isReadingCorrect = getline (in, getstr); in.get (first); } in.unget(); while (!in.eof ()) { in >> Bus_Patch_Abs >> Manu_Id >> Channel >> Mean >> Sigma; if (in.eof ()) break; bool isReadingCorrect = getline (in, getstr);
Further case are not exploited:
source/config/src/utilities.cxx: isReadingCorrect = getline (stream, line); source/config/src/utilities.cxx: isReadingCorrect = getline (stream, line); source/gui1/src/ListView.cxx://[VLA]// in.getline (line, 120); source/version/src/CrocusVerHeaderFile.cxx: in.getline (line, 120);
... and should be !
No data to display
Actions